Fix corner cases for registration reset #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
approved these changes
Apr 27, 2020
Bilb
approved these changes
Apr 27, 2020
neuroscr
reviewed
Apr 27, 2020
| @@ -713,13 +713,8 @@ export class RegistrationTabs extends React.Component<{}, State> { | |||
| } | |||
|
|
|||
| private async resetRegistration() { | |||
| await window.Signal.Data.removeAllIdentityKeys(); | |||
| await window.Signal.Data.removeAllPrivateConversations(); | |||
| window.Whisper.Registration.remove(); | |||
There was a problem hiding this comment.
This removes all keypairs and conversations as well as marks signals registration as not done
There was a problem hiding this comment.
to clarify just talking about 718, which I understand you have to said:
marks signals registration as not done
Why do we no longer need that?
There was a problem hiding this comment.
Registration.remove() calls storage.remove('chromiumRegistrationDone');
so it's just removing a field from the storage, if we wipe the storage then it's the same behaviour
neuroscr
reviewed
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the cases was that the file server tokens weren't removed causing the a fresh registration to upload device links to a different user.
I've changed the reset so it removed all data, and from debugging it doesn't seem to cause issues but i will keep testing.