Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slave Unlink #1112

Merged
merged 2 commits into from
May 4, 2020
Merged

Slave Unlink #1112

merged 2 commits into from
May 4, 2020

Conversation

vincentbavitz
Copy link

@vincentbavitz vincentbavitz commented Apr 30, 2020

Improve unlinking for slave devices.
Further refinements will mend #1111 in a future PR.

image

@Bilb
Copy link
Collaborator

Bilb commented May 3, 2020

I am wondering if that would not be better to keep it as a "Delete account". it's just weird to click on the "Unlink Device" but once you come back to your primary device you will still see your secondary device there.

@neuroscr
Copy link

neuroscr commented May 3, 2020

Well the show devices screen can verify against the file server (for now) before displaying.

Which also means they need to be clearing their devicemap when unpairing

@vincentbavitz
Copy link
Author

I am wondering if that would not be better to keep it as a "Delete account". it's just weird to click on the "Unlink Device" but once you come back to your primary device you will still see your secondary device there.

This could be misinterpreted as deleting the entire account; along with Master.
Plus we want to be able to, in future, unlink completely from secondary device.

@vincentbavitz vincentbavitz merged commit f9c13e4 into oxen-io:clearnet May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants