Integration test logs #1137
Merged
Integration test logs #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Bilb
commented
May 19, 2020
•
Bilb
commented
- fix auto accepted FR when received by bob and sent from Alice's secondary
- add a local file server to be able to test against it during integration tests
- fix bug where autoFR and session request where one another
- fix bug of group sync sent to early after a link success (was dropped sometimes)
- add some tests to validate expected logs are shown (session request triggered, autoFR, ...)
- every tests related to closed groups are still failing, but is probably related to tester code, not tested code. Issue is probably due to mandatory stubbing during test-integration. Will look at this after release. In the mean time, we will validate those features works as expected manually.
Bilb
force-pushed
the
integration-test-logs-rebased
branch
from
71b936c
to
fc3af8b
Compare
msgmaxim
approved these changes
May 22, 2020
Mikunj
approved these changes
May 26, 2020
|
Just need to resolve the conflicts and we should be good to merge |
…th stubbed server
Mikunj
reviewed
Jun 3, 2020
…messenger into integration-test-logs-rebased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.