Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not drop group control message from blocked user #1293

Merged
merged 2 commits into from
Jul 29, 2020
Merged

do not drop group control message from blocked user #1293

merged 2 commits into from
Jul 29, 2020

Conversation

Bilb
Copy link
Collaborator

@Bilb Bilb commented Jul 29, 2020

We block a message from a user in all cases except if:

  • this message is a group message
  • the group already exist in our db
  • the group is not blocked
  • the content of the message is control only

@Bilb Bilb requested a review from Mikunj July 29, 2020 06:40
vincentbavitz
vincentbavitz suggested changes Jul 29, 2020
View reviewed changes
ts/receiver/contentMessage.ts Outdated Show resolved Hide resolved
ts/receiver/contentMessage.ts Outdated Show resolved Hide resolved
@Bilb Bilb force-pushed the fix-drop-message-closed-group branch from 5feea0c to 8505faa Compare July 29, 2020 22:42
@Bilb Bilb force-pushed the fix-drop-message-closed-group branch from 8505faa to 582499b Compare July 29, 2020 22:42
@Bilb Bilb merged commit 8d93bdd into oxen-io:clearnet Jul 29, 2020
@Bilb Bilb deleted the fix-drop-message-closed-group branch July 29, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikunj Mikunj Mikunj approved these changes

@vincentbavitz vincentbavitz vincentbavitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bilb @Mikunj @vincentbavitz