Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure desktop icon for linux appImages #2381

Merged
merged 1 commit into from Jul 1, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion ts/mains/main_node.ts
Expand Up @@ -13,6 +13,7 @@ import {
} from 'electron';

import path, { join } from 'path';
import { platform as osPlatform } from 'process';
import url from 'url';
import os from 'os';
import fs from 'fs';
Expand Down Expand Up @@ -291,8 +292,11 @@ async function createWindow() {
nativeWindowOpen: true,
spellcheck: await getSpellCheckSetting(),
},
// only set icon for Linux, the executable one will be used by default for other platforms
icon:
(osPlatform === 'linux' && path.join(getAppRootPath(), 'images/session/session_icon.png')) ||
undefined,
...picked,
// don't setup icon, the executable one will be used by default
};

if (!_.isNumber(windowOptions.width) || windowOptions.width < minWidth) {
Expand Down