Feature/ses 379/composition rtl support #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated buttons, emoji panel, @mentions
needs more testing
updated Flex component with RTL support, create getWritingDirection selector
use dir in flexbox instead of row-reverse
…referencing user mentions and emoji quick results now support RTL
…ead of using state this is more inline with class component conventions
…rtl-support' into feature/ses-379/composition-rtl-support
Bilb
force-pushed
the
feature/ses-379/composition-rtl-support
branch
from
06f208d
to
bee0015
Compare
|
Looks good to me, have also added the username input into Jira for later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taken #2796 from just updated with latest unstable