forked from signalapp/Signal-Desktop
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ses 476/remove profile picture #2869
Merged
Bilb
merged 26 commits into
oxen-io:unstable
from
Bilb:feature/ses-476/remove-profile-picture
Aug 28, 2023
Merged
Feature/ses 476/remove profile picture #2869
Bilb
merged 26 commits into
oxen-io:unstable
from
Bilb:feature/ses-476/remove-profile-picture
Aug 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still need to do logic and handle multiple modals on screen
…EditProfileDialog show loading spinner while avatar is loading
…n message disabled buttons while loading
confirmed support for svgs with multiple paths
except for linked device profile sync, need to update avatar-update-blue files for linux
- loop until match when validating screenshot - wait 15s and take screenshot when updating screenshot
…e-picture test: fix update profile picture snapshots
…test has been completed
87ca767
to
bc081df
Compare
yougotwill
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
am a dumbass, will help with dumbassing
yougotwill
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.