Closed group chunk1 #2873
Closed
Closed group chunk1 #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the signature work with the admin key, fetching it from the usergroups wrapper
Bilb
force-pushed
the
closed-group-chunk1
branch
from
904e1b6
to
d89ff59
Compare
Bilb
force-pushed
the
closed-group-chunk1
branch
from
4bd7cb6
to
08164f2
Compare
this is because we need to be able to override what is returned by what is in the redux lib slice if needed (libsession data overrides what is in the DB for groupv3)
Bilb
force-pushed
the
closed-group-chunk1
branch
from
e67e91a
to
197383a
Compare
Bilb
force-pushed
the
closed-group-chunk1
branch
from
fc3ece1
to
cd17a08
Compare
until we get the groupinfo name from polling
before testing
Bilb
force-pushed
the
closed-group-chunk1
branch
from
557c2eb
to
5120542
Compare
this is because session doesn't care about the config it receives anymore and just forwards them to libsession
still have some tests to fix
Bilb
force-pushed
the
closed-group-chunk1
branch
from
961e84c
to
9492fdc
Compare
Bilb
force-pushed
the
closed-group-chunk1
branch
from
7d9c600
to
2ee4cad
Compare
Bilb
commented
Oct 15, 2023
Bilb
force-pushed
the
closed-group-chunk1
branch
from
20e679d
to
ed16e9b
Compare
yougotwill
reviewed
Oct 17, 2023
ts/test/session/unit/libsession_wrapper/libsession_wrapper_metagroup_test.ts
Show resolved
Hide resolved
Bilb
force-pushed
the
closed-group-chunk1
branch
from
5427f2d
to
df3a188
Compare
yougotwill
reviewed
Oct 18, 2023
|
|
||
| class GroupSyncJob extends PersistedJob<GroupSyncPersistedData> { | ||
| constructor({ | ||
| identifier, // this has to be the pubkey to which we |
There was a problem hiding this comment.
fixed to identifier, // this has to be the groupPubkey
ts/updater/updater.ts
Outdated
| } | ||
| }, | ||
| 2 * 60 * 1000 | ||
| ); // we do checks from the fileserver every 1 minute. |
| @@ -26,8 +26,7 @@ | |||
| "moduleResolution": "node", // Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). | |||
| "resolveJsonModule": true, | |||
| // Module Resolution Options | |||
| // "baseUrl": "./", // Base directory to resolve non-absolute module names. | |||
| // "paths": {}, // A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. | |||
There was a problem hiding this comment.
Is paths meant to be missing?
|
closing this as we won't merge it except with chunk2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First chunk only gets us to create a group with only us in it, and send messages to ourselves through the group.