fix: make sure we scale image before trying to compress it #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yougotwill
requested changes
Aug 28, 2023
Bilb
force-pushed
the
fix-resize-images-thumbnail
branch
from
32ac567
to
1b73112
Compare
|
just tagging @burtonemily for tracking |
Bilb
force-pushed
the
fix-resize-images-thumbnail
branch
from
5cee62e
to
91dfad5
Compare
Bilb
force-pushed
the
fix-resize-images-thumbnail
branch
from
91dfad5
to
29185c1
Compare
|
Found some issues https://optf.atlassian.net/browse/SES-1244 |
Bilb
force-pushed
the
fix-resize-images-thumbnail
branch
from
5c6c0e7
to
095a9d3
Compare
yougotwill
requested changes
Mar 20, 2024
Bilb
force-pushed
the
fix-resize-images-thumbnail
branch
from
b75b9f1
to
0b55175
Compare
yougotwill
requested changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like the scaling of images was broken and so we were compressing the original picture, to the desired size (kb) but keeping it's original width and height. Which meant we were compressing them way too much
fixing this:
to be this: