feat: add setting to break line on Enter #2929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
reviewed
Sep 26, 2023
Comment on lines
86
to
97
| const initialSetting = window.getSettingValue(SettingsKey.settingsEnterKeyFunction) || true; | ||
|
|
||
| const items = [ | ||
| { | ||
| label: window.i18n('enterSendNewMessageDescription'), | ||
| value: 'enterSend', | ||
| }, | ||
| { | ||
| label: window.i18n('enterNewLineDescription'), | ||
| value: 'enterNewLine', | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
We would prefer to use a boolean for that setting instead of a string.
Would we ever need a third state for this setting? If yes, a string makes sense, but if not, I'd prefer a boolean.
Having a boolean means we can easily store in in redux, and defaults state are easier to manage
Refactor setting to use boolean which is stored in redux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1486