fix: do not try to store contacts not matching pubkey regex in wrapper #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
force-pushed
the
fix-crash-space-in-pubkey
branch
from
c7d646c
to
84fa263
Compare
yougotwill
requested changes
Sep 27, 2023
ts/test/session/unit/libsession_wrapper/libsession_wrapper_contacts_test.ts
Show resolved
Hide resolved
Bilb
force-pushed
the
fix-crash-space-in-pubkey
branch
from
84fa263
to
fa50354
Compare
Bilb
force-pushed
the
fix-crash-space-in-pubkey
branch
2 times, most recently
from
f8bcc10
to
3281821
Compare
also remove existing convo with spaces and 05 on start
Bilb
force-pushed
the
fix-crash-space-in-pubkey
branch
from
3281821
to
7c16ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2916
Fixes #2872