Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unread message count indicator per conversation #2996

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

KeeJef
Copy link
Collaborator

@KeeJef KeeJef commented Dec 11, 2023

Add a unread message count indicator per conversation, next to the read all message down arrow

Cherrypicks and rebases this feature from #2693

image

@KeeJef KeeJef marked this pull request as ready for review December 12, 2023 00:58
@Bilb Bilb changed the base branch from clearnet to unstable March 21, 2024 00:07
ts/components/icon/SessionNotificationCount.tsx Outdated Show resolved Hide resolved
ts/components/icon/SessionNotificationCount.tsx Outdated Show resolved Hide resolved
ts/components/icon/SessionNotificationCount.tsx Outdated Show resolved Hide resolved
ts/components/SessionScrollButton.tsx Outdated Show resolved Hide resolved
ts/components/SessionScrollButton.tsx Outdated Show resolved Hide resolved
@KeeJef KeeJef force-pushed the unread-message-scroll-button-changes branch from 7324e4e to b76ab7e Compare March 22, 2024 03:06
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things to tweak

ts/components/icon/SessionNotificationCount.tsx Outdated Show resolved Hide resolved
ts/components/icon/SessionNotificationCount.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@yougotwill yougotwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

ts/components/icon/SessionNotificationCount.tsx Outdated Show resolved Hide resolved
@Bilb Bilb merged commit f6b1eac into oxen-io:unstable Mar 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants