[multi-device] Handle incoming pairing authorisation message #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachaaaaa
force-pushed
the
handle_incoming_authorisation
branch
from
d63762a
to
6ab05e2
Compare
Mikunj
reviewed
Aug 26, 2019
libtextsecure/message_receiver.js
Outdated
| return true; | ||
| }, | ||
| async handlePairingRequest(pairingRequest) { | ||
| if (!this.validateAuthorisation(pairingRequest)) { |
There was a problem hiding this comment.
Isn't this function async? In this case it would always be true and continue even on invalid requests
libtextsecure/message_receiver.js
Outdated
| if (!this.validateAuthorisation(pairingRequest)) { | ||
| return; | ||
| } | ||
| window.libloki.storage.savePairingAuthorisation(pairingRequest); |
There was a problem hiding this comment.
Do we want to await this incase it fails somehow? or is it fine as is?
libtextsecure/message_receiver.js
Outdated
| ); | ||
| }, | ||
| async handleAuthorisationForSelf(pairingAuthorisation) { | ||
| if (!this.validateAuthorisation(pairingAuthorisation)) { |
libtextsecure/message_receiver.js
Outdated
| } else { | ||
| window.log.warn('Unimplemented pairing authorisation message type'); | ||
| } | ||
| }, | ||
| async handleAuthorisationForContact(pairingAuthorisation) { | ||
| if (!this.validateAuthorisation(pairingAuthorisation)) { |
Mikunj
reviewed
Aug 26, 2019
Co-Authored-By: Mikunj Varsani <Mikunj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The control flow starts at the bottom of the diff and splits in 3.
The authorisation is saved only if valid.
Note:
Whisper.eventsare used to propagate events across the application:secondaryDeviceRegistrationevent: we (the secondary device) have received the grant authorisation from the primary device. This makes the UI transition from the registration page to the inbox page.devicePairingRequestReceivedevent: we (the primary device) have received a pairing authorisation request. This will trigger the UI to prompt the user to accept the pairing if the pairing modal window is open, otherwise it's ignored.