[multi-device] UI for accepting pairing request on Primary devices #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,5 +196,15 @@ | |||
| const dialog = new Whisper.SeedDialogView({ seed }); | |||
| this.el.append(dialog.el); | |||
| }, | |||
| showDevicePairingDialog() { | |||
| const dialog = new Whisper.DevicePairingDialogView(); | |||
| Whisper.events.on('devicePairingRequestReceived', pubKey => | |||
There was a problem hiding this comment.
Do we need to unregister these events after the dialog is closed? And would we be duplicating events if the dialog is opened multiple times?
There was a problem hiding this comment.
Yes it would create multiple events. We should removeListener when dialog is closed or before we add the listener.
Mikunj
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the UI modals that appear when clicking on the "Pair new Device" item in the menu.
There are 3 steps:
Again, events are handled via
Whisper.eventsto allow decoupling.TODO: replace hard-coded strings with
i18ntranslation thingy (in another PR)