Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-device] Fix main header being redrawn every 100ms #434

Merged
merged 1 commit into from Aug 26, 2019

Conversation

sachaaaaa
Copy link

Noticed while debugging that the main header was being constantly redrawn.
This was due to the clipboard code updating the component state every 100ms without checking if the value actually had changed.

Copy link

@BeaudanBrown BeaudanBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof good catch

Copy link

@Mikunj Mikunj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oo nice catch

@sachaaaaa sachaaaaa merged commit 59e1bb4 into oxen-io:multi-device Aug 26, 2019
@sachaaaaa sachaaaaa deleted the fix_clipboard_redraws branch August 26, 2019 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants