[multi-device] Shorter TTL for pairing requests #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachaaaaa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the pairing process should be done with both devices online, the pairing request message should have a short TTL. I've set it to 2 minutes. The timeout for receiving the grant message back on the secondary device is 1 minute, so this leaves 30 seconds for messages to travel in each direction.
Also, I've replaced a
if/else ifstatement with aswitchand moved that into a local function to allow returning the values. This makes the thing slightly more robust against forgettingbreak's, even though usually IDE's and linters pick this error up easily.