separate update group name and group members dialog (add and remove m… #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
force-pushed
the
clearnet
branch
2 times, most recently
from
4e36f01
to
cfe46d4
Compare
Bilb
requested review from
vincentbavitz and
msgmaxim
and removed request for
vincentbavitz
vincentbavitz
suggested changes
Feb 13, 2020
(add and remove members are separated)
neuroscr
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
took a quick look, don't see anything major. I will run some tests with the open group editors to make sure they're fine after this is merged. Also looks like I'll have some conflicts from this in my new open group avatar editor but that's fine. But I would like to urge to merge this so I can continue development on the open group avatar editor, I'm a bit afraid to continue knowing I may need to restructure what I'm doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two options in the group panel (visible for closed chats only)
The show members only allows to remove existing members.
To add new members, use the addMemberButton (equivalent to the invite member for open groups). The dialog will trigger an invite for the user if OpenGroup or add the user to the group if this is a ClosedGroup.