New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor session reset handling #843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First overview pass looks great, I like how this was done. Will go over individual lines later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly some error checking might need to be added and some questions
Moved session reset out from
message_receiver
into a customLokiSessionCipher
.I didn't want to modify
SessionCipher
directly since it resides inlibsignal-protocol.js
.There's also a minor fix that i forgot in #838