Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group profile image upload #878

Merged
merged 8 commits into from Feb 27, 2020
Merged

Group profile image upload #878

merged 8 commits into from Feb 27, 2020

Conversation

Bilb
Copy link
Collaborator

@Bilb Bilb commented Feb 19, 2020

No description provided.

@Bilb Bilb requested a review from Mikunj February 26, 2020 22:20
Mikunj
Mikunj reviewed Feb 27, 2020
View reviewed changes
js/background.js Outdated Show resolved Hide resolved
neuroscr
neuroscr approved these changes Feb 27, 2020
View reviewed changes
Copy link

@neuroscr neuroscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine now, I say merge, so we can QA it before release

@Bilb Bilb merged commit 370467a into oxen-io:clearnet Feb 27, 2020
@Bilb Bilb deleted the group-profile-image branch February 27, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikunj Mikunj Mikunj left review comments

@neuroscr neuroscr neuroscr approved these changes

@msgmaxim msgmaxim Awaiting requested review from msgmaxim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bilb @neuroscr @Mikunj