Try to address duplicate open group message issues after sleep #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing, only one is probably needed)
|
This looks like it might work. If it doesn't then i would look to see if multiple message receivers are instantiated somehow. |
|
Yea that’s also possible; I’ve instrumented one of my dev copies with additional logging to track this already but having stability problems with my hardware still. Also these current events also prove that if multiple message receivers are instantiated somehow, they shouldn't be, we only need this emit handler in one of them (which this PR handles exactly) |
Mikunj
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to address #866, untested but wanted to make the PR easily mergeable as not to miss the next release