make session "work" with .loki tld #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuroscr
approved these changes
Mar 10, 2020
|
fails lint, pls run |
passing number zero to environmental variables UNSETS the variable, pass "0" instead. this commit makes it "work" but is probably not the right fix, that comes later. (tm)
majestrate
force-pushed
the
loki-tld-hack-2020-03-10
branch
from
96338f7
to
8d684f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
clearnetbranchyarn readyrun passes successfully (more about tests here)Description
setting
process.env.NODE_TLS_REJECT_UNAUTHORIZED = 0;is different from settingprocess.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';because javascript.please note that this isn't the correct fix for this code it just makes it "work".