Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS video playback scaling #748

Open
oxenreport opened this issue Dec 2, 2022 · 6 comments
Open

iOS video playback scaling #748

oxenreport opened this issue Dec 2, 2022 · 6 comments
Labels
bug Something isn't working Good first issue Good issues for first time contributors

Comments

@oxenreport
Copy link

oxenreport commented Dec 2, 2022 •
edited

scaling for videos during playback on iOS is problematic, iOS version 16.2, session version 2.4.4
@oxenreport
Copy link
Author

additional comments: video remains zoomed into its playback mode and does not respond with an option to zoom out for proper media display

@DiCE1904
Copy link

DiCE1904 commented Dec 8, 2022

Also, when you rotate your device, the video does not rotate nor scale

@burtonemily burtonemily added the bug Something isn't working label Dec 8, 2022
@burtonemily
Copy link
Collaborator

Hi there, thank you so much for taking the time to report this bug! We hate bugs as much as you do — reporting them helps make Session better for everyone. Our team is currently looking into this issue, we will keep you updated once we know more.

@KeeJef
Copy link
Collaborator

KeeJef commented Feb 8, 2023

Yeah can reproduce here, widescreen media is not properly being scaled which means half of the media gets chopped off, would also be great to have rotation for widescreen media display

@KeeJef KeeJef added the Good first issue Good issues for first time contributors label Feb 8, 2023
@mpretty-cyro mpretty-cyro mentioned this issue Oct 12, 2023
Merged
@mpretty-cyro
Copy link
Collaborator

We've reworked video playback to use native controls in #929 which should fix these issues

@mpretty-cyro
Copy link
Collaborator

@oxenreport @DiCE1904 Are either of you still experiencing these issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Good first issue Good issues for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DiCE1904 @mpretty-cyro @KeeJef @burtonemily @oxenreport