Fixed a few bugs and crashes around media interactions #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a crash when trying to grant permission to access additional photos Fixed a bug where audio files would incorrectly get recognised as voice messages Replaced our custom video/audio players with the native ones (which have additional built-in controls) Updated the errors from SSKKeychainStorage to include useful information Updated layout for audio attachments
|
Fixes #748 |
RyanRory
reviewed
Oct 16, 2023
| @@ -788,13 +789,30 @@ extension Attachment { | |||
| public var isText: Bool { MIMETypeUtil.isText(contentType) } | |||
| public var isMicrosoftDoc: Bool { MIMETypeUtil.isMicrosoftDoc(contentType) } | |||
|
|
|||
| public var documentFileName: String { | |||
There was a problem hiding this comment.
Do we want to localise these default file names?
There was a problem hiding this comment.
Yea probably but they already weren't localised so I wanted to try to minimise changes - since the Strings project is progressing separately in the background I wanted to avoid adding to much additional localisation since it's going to be re-done as it's own project in the future
Hopefully with the updated LintLocalizableStrings it'll be a lot easier to identify all of the unlocalised strings that are missing and we can look to add them as part of the Strings project
RyanRory
approved these changes
Oct 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some example screenshots (left is old, right is new)