Custom Public Chats #57
There are no files selected for viewing
Submodule Pods
updated
from a6c8ea to 68a1e4
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
|
|
||
| @objc(LKNewPublicChatVC) | ||
| final class NewPublicChatVC : OWSViewController { | ||
|
|
||
| // MARK: Components | ||
| private lazy var serverUrlTextField: UITextField = { | ||
| let result = UITextField() | ||
| result.textColor = Theme.primaryColor | ||
| result.font = UIFont.ows_dynamicTypeBodyClamped | ||
| let placeholder = NSMutableAttributedString(string: NSLocalizedString("Enter a Server URL", comment: "")) | ||
| placeholder.addAttribute(.foregroundColor, value: Theme.placeholderColor, range: NSRange(location: 0, length: placeholder.length)) | ||
| result.attributedPlaceholder = placeholder | ||
| result.tintColor = UIColor.lokiGreen() | ||
| result.keyboardAppearance = .dark | ||
|
There was a problem hiding this comment. Would've been nice to also set |
||
| return result | ||
| }() | ||
|
|
||
| private lazy var addButton: OWSFlatButton = { | ||
| let addButtonFont = UIFont.ows_dynamicTypeBodyClamped.ows_mediumWeight() | ||
| let addButtonHeight = addButtonFont.pointSize * 48 / 17 | ||
| let addButton = OWSFlatButton.button(title: NSLocalizedString("Add", comment: ""), font: addButtonFont, titleColor: .white, backgroundColor: .lokiGreen(), target: self, selector: #selector(handleNextButtonTapped)) | ||
| addButton.autoSetDimension(.height, toSize: addButtonHeight) | ||
|
There was a problem hiding this comment. Convention is to not set up constraints here. The reason is that not all constraints can be set up at this point (the view needs to be added as a subview before some of them can be created), so the idea is to wait for that and then set up everything. |
||
| return addButton | ||
| }() | ||
|
|
||
| // MARK: Lifecycle | ||
| override func viewDidLoad() { | ||
| // Background color & margins | ||
| view.backgroundColor = Theme.backgroundColor | ||
| view.layoutMargins = .zero | ||
| // Navigation bar | ||
| navigationItem.leftBarButtonItem = UIBarButtonItem(barButtonSystemItem: .stop, target: self, action: #selector(close)) | ||
| title = NSLocalizedString("Add Public Chat Server", comment: "") | ||
| // Separator | ||
| let separator = UIView() | ||
|
There was a problem hiding this comment. This separator is never added as a subview |
||
| separator.autoSetDimension(.height, toSize: 1 / UIScreen.main.scale) | ||
| separator.backgroundColor = Theme.hairlineColor | ||
|
|
||
| updateButton(enabled: true) | ||
|
|
||
| // Stack view | ||
| let stackView = UIStackView(arrangedSubviews: [ | ||
| serverUrlTextField, | ||
|
There was a problem hiding this comment. An explainer label would be nice |
||
| UIView.vStretchingSpacer(), | ||
| addButton | ||
| ]) | ||
| stackView.axis = .vertical | ||
| stackView.alignment = .fill | ||
| stackView.layoutMargins = UIEdgeInsets(top: 16, left: 16, bottom: 16, right: 16) | ||
| stackView.isLayoutMarginsRelativeArrangement = true | ||
| view.addSubview(stackView) | ||
| stackView.autoPinWidthToSuperview() | ||
| stackView.autoPin(toTopLayoutGuideOf: self, withInset: 0) | ||
| autoPinView(toBottomOfViewControllerOrKeyboard: stackView, avoidNotch: true) | ||
| } | ||
|
|
||
| override func viewDidAppear(_ animated: Bool) { | ||
| super.viewDidAppear(animated) | ||
| serverUrlTextField.becomeFirstResponder() | ||
| } | ||
|
|
||
| // MARK: Interaction | ||
| @objc private func close() { | ||
| dismiss(animated: true, completion: nil) | ||
| } | ||
|
|
||
| @objc private func handleNextButtonTapped() { | ||
| let serverURL = (serverUrlTextField.text?.trimmingCharacters(in: .whitespaces) ?? "").lowercased().replacingOccurrences(of: "http://", with: "https://") | ||
| guard let url = URL(string: serverURL), let scheme = url.scheme, scheme == "https", let _ = url.host else { | ||
| showAlert(title: NSLocalizedString("Invalid server URL provided", comment: ""), message: NSLocalizedString("Please make sure you have provided the full url", comment: "")) | ||
| return | ||
| } | ||
|
|
||
| updateButton(enabled: false) | ||
|
|
||
| // TODO: Upon adding we should fetch previous messages | ||
| LokiPublicChatManager.shared.addChat(server: serverURL, channel: 1) | ||
| .done(on: .main) { _ in | ||
| self.presentingViewController!.dismiss(animated: true, completion: nil) | ||
nielsandriesse marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. You're capturing |
||
| } | ||
| .catch(on: .main) { e in | ||
| self.updateButton(enabled: true) | ||
| self.showAlert(title: NSLocalizedString("Failed to connect to server", comment: "")) | ||
| } | ||
| } | ||
|
|
||
| private func showAlert(title: String, message: String = "") { | ||
| let alert = UIAlertController(title: title, message: message, preferredStyle: .alert) | ||
| alert.addAction(UIAlertAction(title: NSLocalizedString("OK", comment: ""), style: .default, handler: nil)) | ||
| presentAlert(alert) | ||
| } | ||
|
|
||
| private func updateButton(enabled: Bool) { | ||
|
There was a problem hiding this comment. This shouldn't be under the interaction mark |
||
| addButton.setEnabled(enabled) | ||
| addButton.setTitle(enabled ? NSLocalizedString("Add", comment: "") : NSLocalizedString("Connecting to server", comment: "")) | ||
|
|
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the display name on the server