Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global search improvement #855

Closed
wants to merge 3 commits into from
Closed

Global search improvement #855

wants to merge 3 commits into from

Conversation

RyanRory
Copy link
Collaborator

@RyanRory RyanRory commented May 19, 2023 •
edited

  • Use snippet function in FTS5 to get message search results instead of original message
  • Get rid of truncating function and string size calculation

@RyanRory RyanRory changed the title [WIP] Global search improvement Global search improvement May 22, 2023
@RyanRory RyanRory marked this pull request as ready for review May 22, 2023 01:22
mpretty-cyro
mpretty-cyro approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@mpretty-cyro mpretty-cyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, much nicer to be able to use someone else's standardised approach instead of our custom implementation 👍

@mpretty-cyro
Copy link
Collaborator

This has been merged into #751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpretty-cyro mpretty-cyro mpretty-cyro approved these changes

Assignees
No one assigned
Labels
dev-tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RyanRory @mpretty-cyro