Fixed a number of issues with the Notification Service Extension #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mpretty-cyro
commented
Sep 8, 2023
mpretty-cyro
commented
- Fixed an issue where receiving a PN for outgoing messages could break the NotificationServiceExtension
- Fixed an issue where the NotificationServiceExtension could startup in an invalid way resulting in subsequent PNs failing to process
- Fixed an issue where you could incorrectly receive multiple generic notifications after receiving an incoming call notification
- Fixed an issue where the read state syncing might not clear notifications from the notification center
- Fixed an issue with parsing Bencoded data
- Updated the PN subscription to subscribe to CONVO_INFO_VOLATILE notifications (update read state)
- Updated the NotificationServiceExtension to use standard message processing where possible
- Updated the NotificationServiceExtension to update the app badge based on a database query
Fixed an issue where receiving a PN for outgoing messages could break the NotificationServiceExtension Fixed an issue where the NotificationServiceExtension could startup in an invalid way resulting in subsequent PNs failing to process Fixed an issue where you could incorrectly receive multiple generic notifications after receiving an incoming call notification Fixed an issue where the read state syncing might not clear notifications from the notification center Fixed an issue with parsing Bencoded data Updated the PN subscription to subscribe to CONVO_INFO_VOLATILE notifications (update read state) Updated the NotificationServiceExtension to use standard message processing where possible Updated the NotificationServiceExtension to update the app badge based on a database query
RyanRory
approved these changes
Sep 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.