-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libQuic integration via libSession #960
libQuic integration via libSession #960
Conversation
…ration # Conflicts: # Podfile.lock # Session.xcodeproj/project.pbxproj # Session/Meta/Session-Info.plist
This adds keep-alive scripts to help deal with cleaning up xcode simulator devices started by CI jobs. Other changes: - Change /Users/drone -> /Users/$USER in case we use some other CI username in the future. - Simplify the xcode simulator interaction a bit by using xcode's json output + jq to query/manipulate it.
It seems useful to have them run on pushes as well (so that you can push to a local user branch and have the tests run before PRing it).
Libquic integration
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #960 +/- ##
==========================================
+ Coverage 11.62% 12.28% +0.65%
==========================================
Files 649 651 +2
Lines 96950 96623 -327
==========================================
+ Hits 11268 11866 +598
+ Misses 85682 84757 -925 ☔ View full report in Codecov by Sentry. |
Updated to latest libSession commit
• Moved the 'getSwarm' behaviour into a distinct job to prevent duplicate API calls • Updated to the latest libSession (fix libQuic crash) • Updated the JobRunner to support the `runOnceTransient` behaviour and be able to run transient jobs in the app extensions • Reworked the extension file logging to be written directly to the file in a single operation rather than line-by-line via the logger • Fixed a bug where community invites has the wrong author • Fixed a bug where the title on the disappearing messages settings screen was clipping vertically • Fixed a bug where tapping on the disappearing messages setting subtitle could incorrectly appear in read-only state for admins • Fixed a log which contained notification content • Tweaks to extension logging logic
• Reworked the keyboard avoidance in ConversationVC to fix some bugs and simplify the behaviour • Moved the message request footer UI into it's own view • Fixed an issue where paths wouldn't get built for a new isntall • Fixed an issue where a couple of LibSession+Networking errors weren't getting logged correctly • Fixed a log that could be thrown incorrect for a unique constraint failure • Fixed an annoying startup warning due to thread priorities
• Fixed an issue where the message status wouldn't update to the failed state if the MessageSendJob timed-out • Fixed an issue where network issues could result in a backlog of TypingIndicator messages that failed to send (don't bother retrying them) • Fixed an issue where concurrent jobs might not retry correctly if other jobs don't complete or the retry was triggered from the wrong queue • Fixed an issue where the input view could disappear in some cases
• Moved the snode cache and path building into libSession (deleted associated logic) • Moved reachability detection into libSession (remove Reachability dependency) • Fixed a couple of crashes with using libQuic requests • Fixed a bug where the MessageRequestFooterView would show buttons on outgoing message requests
• Removed the 'runOnceTransient' behaviour (no longer have jobs that run before the user exists) • Removed the session id from the message snippet in the conversation list • Fixed an issue where the SyncPushTokensJob might not run because the paths hadn't been built yet
• Fixed a bad memory crash which could occur when returning from the background • Fixed an issue where config messages were incorrectly getting double wrapped in protobuf wrappers
• Updated GRDB and SQLCipher • Shifted the ThreadSettingsViewModel code into a separate function to fix a compilation issue
• Updated to the latest libSession • Updated the code to use the new logger • Fixed a bug in the build script where changes to external libSession dependencies wouldn't result in a rebuild
…he check on debug builds
The main changes in the PR are around reworking the majority of the networking to be run via libQuic:
libQuic
for network requestsBut it also includes a number of general fixes: