Split push notifications across multiple oxenmq instances #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of push notifications we are getting is sometimes hitting a limit on how many requests we can handle through the oxenmq proxy server at once. This suggests oxenmq's proxy thread needs some attention for optimization, but this change in the meantime deals with it in hivemind by starting up OxenMQ instances for push notification handling to distribute the load. This also reduces the number of threads when in such a mode for both the push and the main oxenmq instances as it makes no sense to use hardware_concurrency on *each* of multiple oxenmq servers, especially when running on a 24-thread server.
We can get large bursts of incoming messages that overload the default 200 queue; this increases it substantially (to 4000 or 6000, depending on the oxenmq mode) for the SPNS.
Restarting everything was a bit screwy because READY wasn't sent until hivemind was done waiting for notifiers, but notifiers are set to start after hivemind (via `After`), so we would always timeout and then, as soon as the timeout expires, the notifiers would connect, which was wrong behaviour.
|
This has been live (and working well) on our production server for a few days now; merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of push notifications we are getting is sometimes hitting a limit on how many requests we can handle through the oxenmq proxy server at once. This suggests oxenmq's proxy thread needs some attention for optimization, but this change in the meantime deals with it in hivemind by starting up OxenMQ instances for push notification handling to distribute the load.
This also reduces the number of threads when in such a mode for both the push and the main oxenmq instances as it makes no sense to use hardware_concurrency on each of multiple oxenmq servers, especially when running on a 24-thread server.