Add ZMQ PUSH/PULL sockets to process notifications #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses a performance bottleneck with doing a full processing (involving mutex locks + database transaction) on every new message notification; the overhead and lock contention incurred by the mutex and (mostly) the database transaction mean we can end up processing incoming notifications more slowly than we are getting sent them by the network. This moves all such processing into a dedicated thread, with a simple PUSH/POLL zmq socket structure to feed messages from workers into the notification handler thread.
|
This is live and now working much, much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a performance bottleneck with doing a full processing (involving mutex locks + database transaction) on every new message notification; the overhead and lock contention incurred by the mutex and (mostly) the database transaction mean we can end up processing incoming notifications more slowly than we are getting sent them by the network.
This moves all such processing into a dedicated thread, with a simple PUSH/POLL zmq socket structure to feed messages from workers into the notification handler thread.