-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public networks #117
Merged
Merged
Public networks #117
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
733ecee
support for public networks
nicolasochem 53ee815
Merge branch 'master' into public_networks
nicolasochem bba4b2a
Merge branch 'master' into public_networks
nicolasochem 24f724f
run tezos-node config init and extract bootstrap ppers
nicolasochem 5bc4c0f
add snapshot downloader
nicolasochem 874e07c
switch to tezos container forces us to use sudo
nicolasochem e3201f1
I found a build which works well with edo2net; let's make it default
nicolasochem 41d3cfa
remove exec so the snapshot file is actually deleted
nicolasochem 80f62d0
re-add baker removed by mistake
nicolasochem 776653b
add mkchain support
nicolasochem 5007325
do not error when not public network
nicolasochem d6e33ef
move default protocol to edo2
nicolasochem 4a098f1
don't put history mode in rolling if not public node
nicolasochem 32b222e
point baker to correct data dir
nicolasochem bdd4f97
make config container slimmer
nicolasochem 14a9297
revert custom version
nicolasochem 7d851b2
lint
nicolasochem 0ab21fc
restore default values.yaml to isolated chain
nicolasochem 9fcb451
move wait-for-bootstrap back to the first init container
nicolasochem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,13 @@ | ||
FROM python:alpine | ||
FROM tezos/tezos:v8-release | ||
ENV PYTHONUNBUFFERED=1 | ||
RUN apk add --no-cache --virtual .build-deps gcc musl-dev libffi-dev make \ | ||
|
||
# Note: we install build deps for pip, then remove everything after pip install. | ||
# Then we reinstall runtime deps at the end. | ||
RUN sudo apk add --no-cache --virtual .build-deps gcc py3-pip python3-dev musl-dev libffi-dev make \ | ||
&& pip install base58 pynacl \ | ||
&& apk del .build-deps gcc musl-dev libffi-dev make | ||
&& sudo apk del .build-deps gcc musl-dev libffi-dev make \ | ||
&& sudo apk add --no-cache --virtual install jq gcc python3 py3-pip | ||
COPY entrypoint.py / | ||
ENTRYPOINT ["python", "/entrypoint.py"] | ||
COPY entrypoint.sh / | ||
ENTRYPOINT ["/entrypoint.sh"] | ||
CMD [] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should make the
chain_types
constants somehow. This way it is explicit what are acceptable values. And also so that we don’t have to keep referencing strings everywhere which can very easily introduce bugs. (e.g. hashs/hashes)We can maybe have 3 (maybe just 2) vals:
is_private
,is_isolated
,is_public
. We can prob just go with the first 2. If NOTprivate
AND NOTisolated
, then it must bepublic
. These vals get set by mkchain or whatever.Or we can keep the
eq
checks in Helm templates but set “private” as a string Helm value. soprivate: "private"
and check based off of that constant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have
is_isolated
andis_private
because then they would not be mutually exclusive.What do you recommend? Something like:
Then
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes something like that although I don't think that exact thing will work. Those variables won't be global to all templates.
I think there are a couple of options:
.tpl
file incharts/tezos/templates
. This will contain templates with something like this:if
on.Either way, probably not necessary for getting the F-beta net out the door.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's iterate on this in another PR