Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a mechanism to run only one tezos-node pod per k8s node. #329

Closed
wants to merge 1 commit into from

Conversation

elric1
Copy link
Collaborator

@elric1 elric1 commented Nov 22, 2021

We also turn this functionality on by default in pulumi if we are configured to have 1 node per vm.

We also turn this functionality on by default in pulumi if we are
configured to have 1 node per vm.
@harryttd
Copy link
Collaborator

I don't think we should be customizing such a specific requested feature like this directly in the nodes.yaml. We should templatize the affinity spec of the statefulsets however. A user should be able to specify any affinity spec they want for every node class. In oxheadinfra for example, we are going to want to provide different affinities for different sts's.

I think we should instead simply templatize the affinity spec so that a user can customize it however they want for each sts they spin up. In addition, we write a helper function in _helpers.yaml that contains the new added affinity yaml here. So that a user can still set the flag. But the main node.yaml file should not begin to accumulate many different specific user requested features.

And then obviously user provided affinities should be merged with globally set ones.

@orcutt989
Copy link
Contributor

What would be the use case for that? Isn't that sort of undoing kubernetes?

@elric1
Copy link
Collaborator Author

elric1 commented Nov 30, 2021

Another thing that we could do is provide a way of setting the other resources beyond storage like CPU or RAM. That way if you want 1 tezos node per EC2 VM, say, you could request exclusive access to enough CPUs to make that a reality based on the instance type that you have selected.

@nicolasochem
Copy link
Collaborator

Closing as this is probably not the right way to do it (per our weekly discussion).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants