New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rpc service port for tezos node #526
Conversation
Currently rpc port is export from a NodePort service with a selector, this is not that flexible in some use scenarios. This commit exports the rpc port for tezos node service with ClusterIP, this allows more flexible service route for k8s ingress, e.g. backend rpc services can be directed based on uri path to different tezos node services.
Thanks for this PR. I don't see any problem with implementing your change, but just for my understanding, can you elaborate on what you were trying to do that this solves? FYI this is not a ClusterIP service. It is a headless service as the ClusterIP field is set to |
@harryttd My use scenario is that I am using one ingress to route different rpc traiffic with different URI path to different types of nodes, like rolling nodes and archive nodes. so targeting each pod is what I need, but as the rpc port is not forwarded so I am adding one here. |
Thanks so much for the PR!!! 😄 |
Hi @harryttd @orcutt989 I will elaborate more about my scenario, so I deployed two types of nodes rolling and archive, which deployed two services here, and one nodeport service And I use nginx ingress controller to route different traffic to these two services based on path As for nginx ingress controller, pod IP is being used by upstream service https://github.com/kubernetes/ingress-nginx/blob/main/docs/user-guide/nginx-configuration/annotations.md#service-upstream |
Sounds good we discussed it with @nicolasochem and he explained also. @harryttd should be around with his thoughts and an approval soon. Thanks again for contributing! 🙏 |
Currently rpc port is export from a NodePort service with a selector, this is not that
flexible in some use scenarios.
This commit exports the rpc port for tezos node service with ClusterIP, this allows more flexible service route for k8s ingress, e.g. backend rpc services can be directed based on uri path to different tezos node services.