snapshotEngine: retire snapshot warmer #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orcutt989
changed the title
orcutt989
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesnt appear to be a minimum charge for volume snapshots in AWS, but int DigitalOcean this is $0.01. Snapshot engine creates a substantial amount of volume snapshots so it makes sense to retire the snapshot warmer.
The snapshot warmer would continuously take a snapshot every 10 minutes (DO api timeout) to make sure that there was always the latest available for the next Tezos artifact generation job.
Now this PR gets rid of the snapshot warmer DP and instead has the snapshot maker job take a snapshot, create the pvc, then delete the snapshot so its only around for a short period of time.