snapshotEngine: Dynamic sleep time #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasochem
requested changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sleeping for the configured amount of time this will pull the date on the newest artifact of a given network, version, and history mode.
If the date is older than our sleep time then it starts the artifact creation job.
If the date is newer than it subtracts this from the configured sleep time and sleeps for this new amount.
This was created because we run our nodes pretty slim and sometimes they OOM. This causes the jobs to restart when they are sleeping resulting in more artifacts created than expected with a given sleep time and increased costs.
Now even if the jobs get restarted it will still dynamically calculate if the job needs to sleep or not.