Roles page for orgs #948
Merged
Roles page for orgs #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
commented
Jun 20, 2022
| @@ -35,6 +35,9 @@ const OrgLayout = () => { | |||
| </NavLinkItem> | |||
| ))} | |||
| </Sidebar.Nav> | |||
| <Sidebar.Nav heading="Organization"> | |||
| <NavLinkItem to="../../access">Access & IAM</NavLinkItem> | |||
| </Sidebar.Nav> | |||
There was a problem hiding this comment.
unfortunately the paths here are kind of messed up and I think they depend on my RR fix and another prerelease, which we've been waiting on longer than I expected
david-crespo
commented
Jun 21, 2022
| .filter((u) => !usersInPolicy.has(u.id)) || [] | ||
| ) | ||
| }, [users, policy]) | ||
| } |
There was a problem hiding this comment.
Amusingly, extracting these doesn't save any lines, but the logic is weird enough and identical enough that I think they're worth sharing. Generally I like the idea of being able to treat this stuff like it's part of the API layer when we're in app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #927
It's almost identical to the project access page, so I extracted some of the weirder bits of common logic.