update CockroachDB #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this branch because I'm trying to help debug cockroachdb/cockroach#83706. I'm not exactly sure where we want to end up, but for now, I'm working towards a
stdmallocbuild of 22.1.3. I'm currently trying with Go 1.18 but I don't know if that'll work.How we got here:
Commit 2267c49 causes us to build with
stdmalloc, which causes CockroachDB to usemalloc(3c)and friends rather than a statically-linked jemalloc. I did this to be able to LD_PRELOAD libumem and have it use that to identify corruption.Then it was suggested to use Go 1.18. I began this in 3c24b6c. I created efd1bc2 to supply buildvcs=false during the build because Go 1.18 attempts to use
gitto embed version information into the binary, but the way garbage-compactor works, this fails. (We create agitwrapper that immediately exits so that it doesn't erroneously find the garbage-compactor repo. But exiting unconditionally just causesgo buildto fail -- it doesn't treat this as "repo not found".) This change is probably not right or ideal, but I was just trying to get a working build.I then found that this approach doesn't seem to work on this CockroachDB version.
I thought I'd try the latest Cockroach, and started this with commit dce1b62. Cockroach don't seem to publish the source binaries to the same place any more so I had to update the URL. I immediately ran into a problem with the patches. That's the current state of this.
CC @jclulow