Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include image name in archive zip filename #1282

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Conversation

jgallagher
Copy link
Contributor

This makes three changes, two of which only affect CI (and any following scripts / processes that use CI artifacts):

  1. (Affects everyone) Hubris archive names now have a suffix of -image-X, where X is "default" for most images. E.g., what was once build-psc-c.zip is now build-psc-c-image-default.zip. This matters most for the RoT images; what was once build-gimlet-rot-c.zip (and you had to know what directory it was in and/or inspect its contents to tell if it was an A or B image) is now build-gimlet-rot-c-image-a.zip.
  2. The CI artifacts for the RoT builds now contain both A and B hubris archives.
  3. We no longer upload the artifacts built by the Windows runner (but we do still run the builds on Windows). Since we were cross compiling, I believe (?) these should've been identical, and I don't think anyone was using them.

@steveklabnik
Copy link
Contributor

I believe (?) these should've been identical, and I don't think anyone was using them.

Yep!

@jgallagher jgallagher merged commit ec1a311 into master Apr 17, 2023
63 checks passed
@jgallagher jgallagher deleted the ci-archive-rot-b-images branch April 17, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants