attest: Add attest_len & attest ops.
#1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converted to DRAFT till I test on a gimlet |
labbott
reviewed
Jan 18, 2024
flihp
force-pushed
the
attest
branch
3 times, most recently
from
5010307
to
1bca9d5
Compare
|
this has been tested with dev & mfg builds with platform identity cert signed by staging root https://github.com/oxidecomputer/evidence-room/blob/main/staging/2023-05-12_provisioning/output/platform-identity-root-a.cert.pem on a PSC rev-b & Gimlet rev-c including |
Calling the `attest` op will cause the `Attest` task to produce the signature: `sign(alias_priv, sha3_256(hubpack(log) | nonce))`. The caller can then use other ops from the `Attest` task to verify the signature.
This is the first op supported by sprot that takes both a read and a write lease. Following the existing structure of `handle_request` we add a new `Attest` variant to the TrailingData enum where we store the appropriately sized slice that holds the read lease. As a result we must be more explicit about the lifetimes in the `handle_request` method because it's return value no longer has the same lifetime as the `self` param (3rd lifetime elision rule). The rest is pretty straight forward with the call to `Attest::attest` happending in the match arm for this new `TrailingData` variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling the
attestop will cause theAttesttask to produce the signature:sign(alias_priv, sha3_256(hubpack(log) | nonce)). The caller can then use other ops from theAttesttask to verify the signature.