net: fix several unwraps of complex errors #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
approved these changes
Feb 21, 2024
cbiffle
force-pushed
the
cbiffle/net-unwrap-removal
branch
5 times, most recently
from
1e0c58e
to
b043094
Compare
cbiffle
changed the title
cbiffle
force-pushed
the
cbiffle/net-unwrap-removal
branch
from
b043094
to
3aa358a
Compare
hawkw
approved these changes
Feb 27, 2024
|
The number of places where no VSC chips are used, but the VSC types appear for various reasons, has turned this into quite a game of whack-a-mole. With any luck it will pass the build eventually; I keep failing to predict which builds are affected when I test locally (e.g. the nucleo h7 build winds up depending on the VSC error types). |
cbiffle
force-pushed
the
cbiffle/net-unwrap-removal
branch
from
3aa358a
to
8c4dc9d
Compare
|
Updated numbers post-whackamole: Gimlet E net stack: -16,388 bytes |
This knocks a lot of flash off most netstack task sizes, by removing much of its dependence on the formatting machinery invoked by unwrap. (It's not all gone, because smoltcp still uses it.) Concretely, - Gimlet E net: -16,388 bytes - Monorail server: -8,820 bytes - Sidecar D net: -8 bytes, because something is still pulling in the goo.
cbiffle
force-pushed
the
cbiffle/net-unwrap-removal
branch
from
8c4dc9d
to
96e885e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This knocks about 3.7 kiB (!) off Gimlet's netstack task size, by removing much of its dependence on the formatting machinery invoked by unwrap. (It's not all gone, because smoltcp still uses it.)