Hubris-side changes for removing dispatch_n in idol-runtime
#1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbiffle
force-pushed
the
cbiffle/idol-footgun
branch
2 times, most recently
from
94fed52
to
cfdaa4f
Compare
cbiffle
force-pushed
the
cbiffle/idol-footgun
branch
from
cfdaa4f
to
3ba013c
Compare
labbott
approved these changes
Feb 27, 2024
|
Looks like we're missing an impl of |
cbiffle
force-pushed
the
cbiffle/idol-footgun
branch
3 times, most recently
from
7ee03ea
to
55be7bc
Compare
|
oh, ugh, looks like you're missing one in |
cbiffle
force-pushed
the
cbiffle/idol-footgun
branch
from
55be7bc
to
3ebe400
Compare
This is the Hubris side of oxidecomputer/idolatry#39 and is intended to make it much harder to accidentally lose notifications in an Idol server.
cbiffle
force-pushed
the
cbiffle/idol-footgun
branch
from
3ebe400
to
769fb99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Hubris part of oxidecomputer/idolatry#39, the description of which I've pasted below for your reference:
We ran into an issue last week where we inadvertently replaced a call to
idol_runtime::dispatch_nwith a call toidol_runtime::dispatch. This difficult-to-spot two-character change has the following implications:This is bad, and caused real failures in host startup.
This change alters the API to eliminate
dispatch_nand make notification handling mandatory for all Idol servers -- to opt out of receiving notifications, they must explicitly implementNotificationHandleras stubs. This should prevent this class of error from reoccurring, and has the added benefit of simplifying the runtime implementation -- which I'd previously complicated in a misguided attempt at ergonomics.