i2c_driver should use a counted ringbuf #1660
Conversation
There was a problem hiding this comment.
Looks good to me!
We might want to add #[count(children)] to Trace::RepeatedStart so that true and false entries are counted separately?
We can spare the 4 bytes! And after the |
| "ringbuf-disabled", | ||
| ] | ||
|
|
||
| ringbuf-disabled = ["ringbuf/disabled", "ringbuf/counters-disabled"] | ||
| panic-messages = ["userlib/panic-messages"] | ||
| no-ipc-counters = ["idol/no-counters"] |
There was a problem hiding this comment.
It occurs to me that, since some of the target features disable ringbufs and counters, we should maybe just have the features for those targets also disable IPC counters, rather than explicitly setting the no-ipc-counters feature in the app.toml for those targets...but that's something to do separately.
No description provided.