Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add what's being built to job names #1665

Merged
merged 3 commits into from
Mar 19, 2024
Merged

ci: add what's being built to job names #1665

merged 3 commits into from
Mar 19, 2024

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Mar 18, 2024

Currently, the GitHub Actions UI contains a giant list of thbings which are all called "dist-single". It would be nice if they had names that actually indicated which app was being built.

This commit does that.

Currently, the GitHub Actions UI contains a giant list of thbings which
are all called "dist-single". It would be nice if they had names that
actually indicated which app was being built.

This commit does that.
@hawkw hawkw requested a review from labbott March 18, 2024 23:44
@hawkw
Copy link
Member Author

hawkw commented Mar 19, 2024

Now it looks like this, which is maybe a little better?
image

@jclulow
Copy link
Contributor

jclulow commented Mar 19, 2024

Now it looks like this, which is maybe a little better?
image

Could you remove the common prefix, so we could see more of the different per-job bit?

Copy link
Collaborator

@labbott labbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is great thanks!

@hawkw
Copy link
Member Author

hawkw commented Mar 19, 2024

Could you remove the common prefix, so we could see more of the different per-job bit?

Yeah, I think that's better, will do!

@hawkw
Copy link
Member Author

hawkw commented Mar 19, 2024

@labbott thanks for the review! I believe that, before this can merge, someone with admin access to the repo will need to change the required checks in the repo's branch protection settings, since the names of the jobs have changed.

@labbott labbott merged commit 3325c63 into master Mar 19, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants