Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAX31790 to IPCC inventory #1668

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Add MAX31790 to IPCC inventory #1668

merged 1 commit into from
Mar 21, 2024

Conversation

mkeeter
Copy link
Collaborator

@mkeeter mkeeter commented Mar 20, 2024

The host will eventually want fan tachometer data in its IPCC inventory; this PR adds MAX31790 sensor IDs to our enum InventoryData in preparation.

The new variant is added at the end to preserve existing serialization.

Copy link
Contributor

@rmustacc rmustacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Thanks, Matt!

@rmustacc
Copy link
Contributor

rmustacc commented Mar 20, 2024

BRM42220071 # /usr/platform/oxide/bin/ipcc inventory 0x47
metadata:
    version: 0x0
    entries: 0x48
U321 (71) -- Result: 0 [Success]
Type 14, Payload: 0x18 bytes
0000   63 00 00 00 64 00 00 00 65 00 00 00 66 00 00 00  |c...d...e...f...|
0010   67 00 00 00 68 00 00 00                          |g...h...        |

This all appears to be working.

@mkeeter mkeeter enabled auto-merge (squash) March 21, 2024 14:20
@mkeeter mkeeter merged commit 8f5934b into master Mar 21, 2024
103 checks passed
@mkeeter mkeeter deleted the max31790-sensor-ids branch March 21, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants