fully qualify SpiError, task_net_api::{SendError, RecvError} types in Idol
#1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a collision between `task_net_api::{SendError, RecvError}`
and the `smoltcp::{SendError, RecvError}` types that confuses Humility,
as in:
```console
humility: WARNING: RecvError matches more than one enum: task_net_api::RecvError as GOFF 0x00027769 (object 2), smoltcp::socket::udp::RecvError as GOFF 0x0004f824 (object 2)
humility: WARNING: SendError matches more than one enum: smoltcp::socket::udp::SendError as GOFF 0x0000f7d3 (object 2), task_net_api::SendError as GOFF 0x0002778d (object 2)
```
This fixes a collision between the `drv_spi_api::SpiError` and `gateway_messages::sp_to_mgs::SpiError` types that confuses Humility, as in: ```console humility: WARNING: SpiError matches more than one enum: drv_spi_api::SpiError as GOFF 0x0000786b (object 4), gateway_messages::sp_to_mgs::SpiError as GOFF 0x00010532 (object 4) humility: WARNING: SpiError matches more than one enum: drv_spi_api::SpiError as GOFF 0x0000786b (object 4), gateway_messages::sp_to_mgs::SpiError as GOFF 0x00010532 (object 4) humility: WARNING: SpiError matches more than one enum: drv_spi_api::SpiError as GOFF 0x0000786b (object 4), gateway_messages::sp_to_mgs::SpiError as GOFF 0x00010532 (object 4) humility: WARNING: SpiError matches more than one enum: drv_spi_api::SpiError as GOFF 0x0000786b (object 4), gateway_messages::sp_to_mgs::SpiError as GOFF 0x00010532 (object 4) humility: WARNING: SpiError matches more than one enum: drv_spi_api::SpiError as GOFF 0x0000786b (object 4), gateway_messages::sp_to_mgs::SpiError as GOFF 0x00010532 (object 4) ```
mkeeter
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes name collisions between
drv_spi_api::SpiErrorandgateway_messages::sp_to_mgs::SpiError, and betweentask_net_api::{SendError, RecvError}andsmoltcp::{SendError, RecvError}that confuses Humility, as in:I'd also like to add a CI pass for detecting these by ensuring that
humility hiffy -ldoesn't return any stderr messages on the archive. However, there's an unrelated warning from that commandwhich I haven't fixed yet. We could maybe pipe its stdout into
grep "matches more than one enum"though.