Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXTI IRQ docs improvements #1699

Merged
merged 3 commits into from
Apr 1, 2024
Merged

EXTI IRQ docs improvements #1699

merged 3 commits into from
Apr 1, 2024

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Mar 30, 2024

This branch contains two commits, both related to documentation for EXTI GPIO IRQs:

  • 1d069b7 fixes a wrong comment in the nucleo-user-button demo task
  • 87c5027 adds example code for actually using EXTI IRQs to the stm32xx-sys crate

@hawkw hawkw marked this pull request as ready for review March 30, 2024 22:11
The comment in the `nucleo-user-button` demo task gets the order of
arguments to `sys.gpio_irq_control` backwards. Since this example task
is intended to demonstrate how to use this API, we should definitely fix
this. Thanks @bcantrill for catching it!
@hawkw hawkw force-pushed the eliza/fix-gpio-irq-comment branch from 1e6697f to 1d069b7 Compare April 1, 2024 16:40
@hawkw hawkw changed the title nucleo-user-button: fix backwards comment EXTI IRQ docs improvements Apr 1, 2024
@hawkw hawkw requested a review from cbiffle April 1, 2024 17:24
@hawkw hawkw enabled auto-merge (rebase) April 1, 2024 23:43
@hawkw hawkw merged commit 0e7022d into master Apr 1, 2024
93 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants