build/i2c: generate range matches #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbiffle
force-pushed
the
cbiffle/i2c-config-range-matches
branch
from
bf15907
to
467f474
Compare
hawkw
approved these changes
Apr 4, 2024
We've noticed the compiler tends to generate better code for integer
range matches of the form
match x {
0..=7 => a,
7..=10 => b,
_ => c,
}
as compared to
match x {
0
| 1
| 2
| 3
| 4
| 5
| 6
| 7 => a,
// and so on
}
Also, Clippy in recent nightly has started objecting to the "cascade of
digits" form. Rather than suppressing that warning, I thought I'd
convert the biggest matches in our codegen output to use ranges.
This commit uses rangemap to automatically consolidate adjacent ranges
of integers into a convenient match statement. I've also factored out
the code from the two places it was used.
cbiffle
force-pushed
the
cbiffle/i2c-config-range-matches
branch
from
467f474
to
07cdfbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed the compiler tends to generate better code for integer range matches of the form
as compared to
Also, Clippy in recent nightly has started objecting to the "cascade of digits" form. Rather than suppressing that warning, I thought I'd convert the biggest matches in our codegen output to use ranges.
This commit uses rangemap to automatically consolidate adjacent ranges of integers into a convenient match statement. I've also factored out the code from the two places it was used.