fix ROT_IRQ regressions from #1696 #1736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes a pair of regressions I introduced in PR #1696 :
sprot: fix backwards ROT_IRQ edge detection (8be5f3c)
In PR sprot: turn
ROT_IRQ
into a real IRQ #1696, I broke thedrv-stm32h7-sprot-server
code for waiting forROT_IRQ
to change state. TheROT_IRQ
signal is active low (and inthe schematic it's called
ROT_TO_SP_IRQ_L
), but in the code, the pinis just referred to as
ROT_IRQ
, so I configured edge sensitivitybackwards, meaning we missed the IRQ signal. Oops, my bad.
This commit changes the edge sensitivity to wait for the falling edge
when waiting for
ROT_IRQ
to be asserted, and to wait for the risingedge when waiting for it to be deasserted, instead of the other way
around. Now, it actually works correctly.
psc: fix wrong
ROT_IRQ
pin (5046b54)Whoops, I accidentally copied the configuration from Gimletlet rather
than from Gimlet/Sidecar, so this is wrong.