Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler bump in #1703 left us with a mere 24 bytes of
stackmargin
onhost-sp-comms
(down from about 1 KiB). This manifests as sporadic stack overflows, basically if we hit an interrupt at exactly the wrong time.Cores are collected in
/staff/dogfood/cores-collected-20240507
. All of the per-task cores show the same issue:This PR bumps us back to a healthy 1 KiB of stack margin. Figuring out why
rustc
decided to sabotage our stacks is left as an exercise for the reader.