psc: turn PSU back on even if it says !OK #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #1800. In brief: the PSU won't start asserting OK again until it's re-enabled, whereas we were waiting to see OK before we would re-enable. This produced something of a stalemate.
hawkw
approved these changes
May 23, 2024
cbiffle
commented
May 23, 2024
| @@ -73,10 +73,6 @@ | |||
| //! - Wait some time for it to wake. | |||
| //! - Start watching the fault signal again. | |||
| //! | |||
| //! We count the number of times we have had to reset a PSU in a row, and if the | |||
There was a problem hiding this comment.
In case anyone's curious, I removed this because it was leftover and doesn't accurately describe the final behavior of the sequencer, which will attempt to resuscitate a PSU forever right now (at intervals).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1800.
In brief: the PSU won't start asserting OK again until it's re-enabled, whereas we were waiting to see OK before we would re-enable. This produced something of a stalemate.