-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I2C device tree descriptions in TOML #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good.
Be careful include!
-ing generated files into a module with user definitions. Currently defining things in the config named, say, main
will cause weird compile errors. Wrapping the include!
in a module, e.g. mod i2c { ... }
, would fix that.
Agreed; all of the generated code is wrapped with |
This is the Humility side of the Hubris I2C TOML work as described in oxidecomputer/hubris#238.
This work adds a description of I2C in TOML as part of an application
definition, allowing this description to be pulled out of hand-written
code, and into code that is automatically generated as part of the
build process. This allows for Humility to know the I2C device tree
based on the archive -- which in turn allows for much more robust
tooling for I2C and I2C-based protcols like PMBus. In addition to
adding support for I2C in TOML and definitions for every platform that
supports I2C, this work also:
Port::Default